Update CONTRIBUTING.md#7570
Merged
Merged
Conversation
Removed "If you are unable to build to iOS/OSX due to using a Windows machine, please let the reviewers know so they can double check that platform themselves." because we added a way to test mac on windows, it's in/around line 72
Contributor
|
I'll merge once travis is done. 👍 |
Contributor
|
Man, iOS tests are taking a while! (almost 45 mins now)... |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
18 tasks
Contributor
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed "If you are unable to build to iOS/OSX due to using a Windows machine, please let the reviewers know so they can double check that platform themselves." because we added a way to test mac on windows, it's in/around line 72
Details
Removed "If you are unable to build to iOS/OSX due to using a Windows machine, please let the reviewers know so they can double check that platform themselves." because we added a way to test mac on windows, it's in/around line 72
Fixed Issues
$ GH_LINK
Tests
Check CONTRIBUTING.md to ensure "If you are unable to build to iOS/OSX due to using a Windows machine, please let the reviewers know so they can double check that platform themselves." is removed
QA Steps
Check CONTRIBUTING.md to ensure "If you are unable to build to iOS/OSX due to using a Windows machine, please let the reviewers know so they can double check that platform themselves." is removed
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android